Fix proto tool for large column numbers#126
Merged
elenagaljak-db merged 2 commits intomainfrom Mar 11, 2026
Merged
Conversation
teodordelibasic-db
previously approved these changes
Mar 11, 2026
Contributor
teodordelibasic-db
left a comment
teodordelibasic-db
left a comment
There was a problem hiding this comment.
LGTM, you can add a short entry to python/NEXT_CHANGELOG.md.
elenagaljak-db
previously approved these changes
Mar 11, 2026
Contributor
elenagaljak-db
left a comment
elenagaljak-db
left a comment
There was a problem hiding this comment.
Should we fix this in other tools too?
danilonajkov-db
dismissed stale reviews from elenagaljak-db and teodordelibasic-db
via
1e119e4
elenagaljak-db
approved these changes
Mar 11, 2026
Contributor
elenagaljak-db
left a comment
elenagaljak-db
left a comment
There was a problem hiding this comment.
Thanks for making these changes!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Protobuf has reserved columns 19000-19999. When generating proto we need to skip these. Currently generating such a proto fails.
How is this tested?
Manually testing with dbr's max column num of 32000